leixm commented on code in PR #327:
URL: https://github.com/apache/incubator-uniffle/pull/327#discussion_r1023467688
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -186,6 +186,11 @@ public void sendShuffleData(SendShuffleDataRequest req,
String appId = req.getAppId();
int shuffleId = req.getShuffleId();
long requireBufferId = req.getRequireBufferId();
+ long sendTime = req.getSendTime();
+ if (sendTime > 0) {
+
shuffleServer.getGrpcMetrics().recordSendTime(ShuffleServerGrpcMetrics.SEND_SHUFFLE_DATA_METHOD,
Review Comment:
I don't think the amount of data will cause great fluctuations in latency.
For example, 100K costs 1ms, and 1M costs 10ms. This seems like a normal
fluctuation, but it may rise to 10s when the server load is high (according to
observations in the production environment) , Of course, if we consider the
amount of data, we can divide the sending time by a certain amount of data. Do
you have any better suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
