jerqi commented on code in PR #327:
URL: https://github.com/apache/incubator-uniffle/pull/327#discussion_r1023487249
##########
proto/src/main/proto/Rss.proto:
##########
@@ -90,6 +91,7 @@ message GetMemoryShuffleDataRequest {
int32 partitionId = 3;
int64 lastBlockId = 4;
int32 readBufferSize = 5;
+ int64 sendTime = 6;
Review Comment:
Time a duration. This should be timestamp.
##########
proto/src/main/proto/Rss.proto:
##########
@@ -90,6 +91,7 @@ message GetMemoryShuffleDataRequest {
int32 partitionId = 3;
int64 lastBlockId = 4;
int32 readBufferSize = 5;
+ int64 sendTime = 6;
Review Comment:
Time is a duration. This should be timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
