jerqi commented on code in PR #327:
URL: https://github.com/apache/incubator-uniffle/pull/327#discussion_r1023579632
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -186,6 +186,16 @@ public void sendShuffleData(SendShuffleDataRequest req,
String appId = req.getAppId();
int shuffleId = req.getShuffleId();
long requireBufferId = req.getRequireBufferId();
+ long sendTime = req.getTimestamp();
+ if (sendTime > 0) {
+ /*
+ * Here we record the transport time, but we don't consider the impact of
data size on transport time.
+ * The amount of data will not cause great fluctuations in latency. For
example, 100K costs 1ms,
+ * and 1M costs 10ms. This seems like a normal fluctuation, but it may
rise to 10s when the server load is high.
+ * */
+
shuffleServer.getGrpcMetrics().recordTransportTime(ShuffleServerGrpcMetrics.SEND_SHUFFLE_DATA_METHOD,
Review Comment:
> Perhaps we can add a comment stating that the time of the client machine
and the server machine should be in sync. For the case of less than 0, we do a
judgment filter, but time out of sync will also affect metrics
OK. actually we should have a document to tell users that how to use the
metrics and what to notice. But we don't have such documents, so we can only
add some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
