jerqi commented on code in PR #383:
URL: https://github.com/apache/incubator-uniffle/pull/383#discussion_r1038997571
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -59,4 +59,9 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
}
return serverToClients.get(shuffleServerInfo);
}
+
+ // Only for tests
+ public synchronized void cleanupCache() {
Review Comment:
Is this necessary? Maybe we could use reflection in our test code. I just
have some concern about it. I don't know the best practice. @LuciferYang Could
you give some suggestion?
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -59,4 +59,9 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
}
return serverToClients.get(shuffleServerInfo);
}
+
+ // Only for tests
+ public synchronized void cleanupCache() {
Review Comment:
Is this necessary? Maybe we could use reflection in our test code. I just
have some concern about it. I don't know the best practice. @LuciferYang Could
you give me some suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
