zuston commented on code in PR #383:
URL: https://github.com/apache/incubator-uniffle/pull/383#discussion_r1039178995
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -59,4 +59,9 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
}
return serverToClients.get(shuffleServerInfo);
}
+
+ // Only for tests
+ public synchronized void cleanupCache() {
Review Comment:
The original intention of this method is to solve the problem of client
closed by other test cases due to existence of cache. This will make some test
cases flaky.
> It just reassigns clients, but doesn't clear the state of the original
one, such as close shuffleServerClient
You mean we'd better to close the client when cleaning the cache. Right?
@LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
