LuciferYang commented on code in PR #383:
URL: https://github.com/apache/incubator-uniffle/pull/383#discussion_r1039182041
##########
internal-client/src/main/java/org/apache/uniffle/client/factory/ShuffleServerClientFactory.java:
##########
@@ -59,4 +59,9 @@ public synchronized ShuffleServerClient
getShuffleServerClient(
}
return serverToClients.get(shuffleServerInfo);
}
+
+ // Only for tests
+ public synchronized void cleanupCache() {
Review Comment:
Yes, if we implement such method for `ShuffleServerClientFactory`, it should
be more robust. Otherwise, when `cleanupCache` is called, the resources in
previous `clients` may leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
