jerqi commented on code in PR #383:
URL: https://github.com/apache/incubator-uniffle/pull/383#discussion_r1039217307
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -309,10 +320,7 @@ void processPendingEvents() throws Exception {
}
private void cleanupFlushEventData(ShuffleDataFlushEvent event) {
- ShuffleBuffer shuffleBuffer = event.getShuffleBuffer();
- if (shuffleBuffer != null) {
- shuffleBuffer.clearInFlushBuffer(event.getEventId());
- }
+ event.doCleanup();
if (shuffleServer != null) {
Review Comment:
> Yes. But the `shuffleBufferManager` is not a member variable for
`ShuffleBuffer`
We can add this logic as a cleanup callback. It's ok although
ShuffleBufferManager is not a member variable for ShuffleBuffer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
