jerqi commented on code in PR #400:
URL: https://github.com/apache/incubator-uniffle/pull/400#discussion_r1046745155
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/MemoryClientReadHandler.java:
##########
@@ -47,15 +54,19 @@ public MemoryClientReadHandler(
int shuffleId,
int partitionId,
int readBufferSize,
- ShuffleServerClient shuffleServerClient) {
+ ShuffleServerClient shuffleServerClient,
+ Roaring64NavigableMap expectBlockIds,
+ Roaring64NavigableMap processBlockIds) {
Review Comment:
I think this pr need the lazy creation of memory handler. It will help us
simplify the logic of this pr. You can implement it in another pr. And we merge
that pr first . It's also ok to implement them in this pr at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
