jerqi commented on code in PR #400:
URL: https://github.com/apache/incubator-uniffle/pull/400#discussion_r1048058597
##########
storage/src/main/java/org/apache/uniffle/storage/factory/ShuffleHandlerFactory.java:
##########
@@ -116,14 +119,21 @@ public ClientReadHandler
createSingleReplicaClientReadHandler(CreateShuffleReadH
private ClientReadHandler
getMemoryClientReadHandler(CreateShuffleReadHandlerRequest request,
ShuffleServerInfo ssi) {
ShuffleServerClient shuffleServerClient =
ShuffleServerClientFactory.getInstance().getShuffleServerClient(
ClientType.GRPC.name(), ssi);
+ Roaring64NavigableMap expectTaskIds;
+ if (request.isExpectedTaskIdsBitmapFilterEnable()) {
+ Roaring64NavigableMap realExceptBlockIds =
RssUtils.cloneBitMap(request.getExpectBlockIds());
+ realExceptBlockIds.xor(request.getProcessBlockIds());
+ expectTaskIds = RssUtils.generateTaskIdBitMap(realExceptBlockIds,
request.getIdHelper());
+ } else {
+ expectTaskIds = request.getExpectTaskIds();
Review Comment:
Why should `epectTaskIds` be `request#getExpectTaskIds()` instead of `null`?
##########
storage/src/main/java/org/apache/uniffle/storage/factory/ShuffleHandlerFactory.java:
##########
@@ -116,14 +119,21 @@ public ClientReadHandler
createSingleReplicaClientReadHandler(CreateShuffleReadH
private ClientReadHandler
getMemoryClientReadHandler(CreateShuffleReadHandlerRequest request,
ShuffleServerInfo ssi) {
ShuffleServerClient shuffleServerClient =
ShuffleServerClientFactory.getInstance().getShuffleServerClient(
ClientType.GRPC.name(), ssi);
+ Roaring64NavigableMap expectTaskIds;
+ if (request.isExpectedTaskIdsBitmapFilterEnable()) {
Review Comment:
In current implement, we only enable `taskbitmapFilter` when the partition
is skewed. Could we turn on the filter condition for only multi replicas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
