jerqi commented on code in PR #400:
URL: https://github.com/apache/incubator-uniffle/pull/400#discussion_r1047982553
##########
storage/src/main/java/org/apache/uniffle/storage/handler/impl/MemoryClientReadHandler.java:
##########
@@ -65,15 +72,22 @@ public MemoryClientReadHandler(
int partitionId,
int readBufferSize,
ShuffleServerClient shuffleServerClient,
- Roaring64NavigableMap expectTaskIds,
- boolean expectedTaskIdsBitmapFilterEnable) {
+ Roaring64NavigableMap expectBlockIds,
+ Roaring64NavigableMap processBlockIds,
+ boolean expectedTaskIdsBitmapFilterEnable,
+ IdHelper idHelper) {
this.appId = appId;
this.shuffleId = shuffleId;
this.partitionId = partitionId;
this.readBufferSize = readBufferSize;
this.shuffleServerClient = shuffleServerClient;
- this.expectTaskIds = expectTaskIds;
- this.expectedTaskIdsBitmapFilterEnable = expectedTaskIdsBitmapFilterEnable;
+ if (expectedTaskIdsBitmapFilterEnable) {
Review Comment:
Could we calculate taskBitmap in the upper layer? Could we remove
`expectBlockIds` and `processBlockIds`? It's enough to pass the paramter
`expectTaskIds`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
