xianjingfeng commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1050348331
##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferManager.java:
##########
@@ -115,7 +115,9 @@ public StatusCode cacheShuffleData(String appId, int
shuffleId,
ShuffleBuffer buffer = entry.getValue();
long size = buffer.append(spd);
- updateSize(size, isPreAllocated);
+ if (!isPreAllocated) {
Review Comment:
We can modify the UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
