xianjingfeng commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1050348208
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -226,26 +227,21 @@ public void sendShuffleData(SendShuffleDataRequest req,
return;
}
final long start = System.currentTimeMillis();
+ manager.markBufferInUse(requireBufferId);
Review Comment:
> Well, this could happen, but in practice it should be extremely rare.
In current codebase, it is extremely rare too.
> Even if the above case happens, the outcome would be double releasing
`usedMemory` size which has a safe bet that it will never decreased to less
than zero.
It will lead to OOM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
