advancedxy commented on code in PR #428:
URL: https://github.com/apache/incubator-uniffle/pull/428#discussion_r1050360280
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -121,6 +124,11 @@ public ShuffleTaskManager(
leakShuffleDataCheckExecutorService.scheduleAtFixedRate(
() -> checkLeakShuffleData(), leakShuffleDataCheckInterval,
leakShuffleDataCheckInterval, TimeUnit.MILLISECONDS);
+ this.triggerFlushExecutorService =
Executors.newSingleThreadScheduledExecutor(
+ ThreadUtils.getThreadFactory("triggerShuffleBufferManagerFlush"));
+ triggerFlushExecutorService.scheduleAtFixedRate(
Review Comment:
> Is it only useful for tests?
Not exactly. I think it would be helpful when we are optimizing the flush
logic later. I'm currently working on that. And It is sub-optimal to flush
memory coupled with `cacheShuffleData`, It may cause spike traffic to
disk/hdfs. We can flush memory earlier and dynamically, make it more balanced
considering a large amount of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
