xianjingfeng commented on code in PR #415:
URL: https://github.com/apache/incubator-uniffle/pull/415#discussion_r1050528630
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java:
##########
@@ -182,6 +190,15 @@ private void registerMetrics() {
jettyServer.addServlet(
new CommonMetricsServlet(JvmMetrics.getCollectorRegistry(), true),
"/prometheus/metrics/jvm");
+
+ String ip = RssUtils.getHostIp();
+ int port = coordinatorConf.getInteger(CoordinatorConf.RPC_SERVER_PORT);
+ metricReporter = MetricReporterFactory.getMetricReporter(coordinatorConf,
ip + "-" + port);
Review Comment:
> could we set id for coordinator just like how shuffle server assembly it.
It is ok for me
> Also another problem, it should be possible to set the port to zero and
let the system decides which port is free.
> We may need to create an issue to track this case.
Yes, you can raise a new pr to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
