advancedxy commented on code in PR #415:
URL: https://github.com/apache/incubator-uniffle/pull/415#discussion_r1050549470
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -236,6 +243,13 @@ private void registerMetrics() {
jettyServer.addServlet(
new CommonMetricsServlet(JvmMetrics.getCollectorRegistry(), true),
"/prometheus/metrics/jvm");
+
+ metricReporter =
MetricReporterFactory.getMetricReporter(shuffleServerConf, id);
Review Comment:
1. `Class.forName(name);` cloud throw an exception if the class is not
defined?
2. `(AbstractMetricReporter) constructor.newInstance(conf, instanceId);`
cast exception would be thrown if the misconfigured class is not an subclass of
`AbstractMetricReporter`.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
