advancedxy commented on code in PR #415:
URL: https://github.com/apache/incubator-uniffle/pull/415#discussion_r1050594953
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -236,6 +243,13 @@ private void registerMetrics() {
jettyServer.addServlet(
new CommonMetricsServlet(JvmMetrics.getCollectorRegistry(), true),
"/prometheus/metrics/jvm");
+
+ metricReporter =
MetricReporterFactory.getMetricReporter(shuffleServerConf, id);
Review Comment:
> I think throw an exception is better in this case. This is a user's
mistake and the user will restart the server. If we just logging the error and
some partitions have been assigned to this server, it will be troublesome.
For metrics report cases, I don't think is troublesome.
But I'm ok to raise an exception here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
