jerqi commented on code in PR #480:
URL: https://github.com/apache/incubator-uniffle/pull/480#discussion_r1068876327


##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -259,7 +259,7 @@ public SendShuffleDataResult sendShuffleData(String appId, 
List<ShuffleBlockInfo
     }
 
     // maintain the count of blocks that have been sent to the server
-    Map<Long, AtomicInteger> blockIdsTracker = Maps.newConcurrentMap();
+    Map<Long, AtomicInteger> blockIdsTracker = Maps.newHashMap();

Review Comment:
   This variable will be accessed by multiple threads in `sendShuffleDataAsync`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to