jerqi commented on code in PR #480:
URL: https://github.com/apache/incubator-uniffle/pull/480#discussion_r1069509476
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -259,7 +259,7 @@ public SendShuffleDataResult sendShuffleData(String appId,
List<ShuffleBlockInfo
}
// maintain the count of blocks that have been sent to the server
- Map<Long, AtomicInteger> blockIdsTracker = Maps.newConcurrentMap();
+ Map<Long, AtomicInteger> blockIdsTracker = Maps.newHashMap();
Review Comment:
You're right. But it's more safe to use `cocurrentHashmap`. If we modify
this logic one day, we could forget to change this type to `ConcurrentHashmap`.
If you still think it's meaningful to modify this type, I think we could add
some comments to explain why we don't use `ConcurrentHashmap` and remind us of
this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
