jerqi commented on code in PR #480:
URL: https://github.com/apache/incubator-uniffle/pull/480#discussion_r1068892517
##########
client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java:
##########
@@ -259,7 +259,7 @@ public SendShuffleDataResult sendShuffleData(String appId,
List<ShuffleBlockInfo
}
// maintain the count of blocks that have been sent to the server
- Map<Long, AtomicInteger> blockIdsTracker = Maps.newConcurrentMap();
+ Map<Long, AtomicInteger> blockIdsTracker = Maps.newHashMap();
Review Comment:
> no, it's not shared since a new instance is created each time you call the
method.
You can see for more details.
https://github.com/apache/incubator-uniffle/blob/f4048fc9dc11b1da642e6e97e540ea98b57d490c/client/src/main/java/org/apache/uniffle/client/impl/ShuffleWriteClientImpl.java#L172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
