advancedxy commented on code in PR #491:
URL: https://github.com/apache/incubator-uniffle/pull/491#discussion_r1071924464
##########
deploy/kubernetes/operator/Makefile:
##########
@@ -16,12 +16,16 @@
#
# REGISTRY URL to use all building/pushing image targets
-REGISTRY ?= UNKNOWN_REGISTRY
+REGISTRY ?= ''
+
+ifneq ('', ${REGISTRY})
+REGISTRY := $(addsuffix /, ${REGISTRY})
+endif
MODULES ?= webhook controller
# ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be
downloaded by envtest binary.
-ENVTEST_K8S_VERSION = 1.22.1
+ENVTEST_K8S_VERSION = 1.24.1
Review Comment:
> Actually my question is why update envtest?
To quote:`upgrade envtest to 1.24.1 to support Apple M1 chips`. envtest
v1.22.x doesn't support M1 chip, not publish related arm archives. So, you
cannot test the controller on M1.
The operator's required k8s in go.mod doesn't change, and still goes to
1.22 (k8s.io/api v0.22.x). And RSS's operator doesn't seem to use too much
advanced features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
