zuston commented on code in PR #491:
URL: https://github.com/apache/incubator-uniffle/pull/491#discussion_r1073258082
##########
deploy/kubernetes/operator/pkg/webhook/util/util.go:
##########
@@ -192,16 +196,27 @@ func HasZeroApps(pod *corev1.Pod) bool {
return true
}
url := fmt.Sprintf("http://%v:%v/metrics/server";, pod.Status.PodIP,
port)
- req := gorequest.New().Timeout(time.Second * 15).Get(url).Type("json")
- resp, body, errs := req.EndBytes()
- if len(errs) > 0 {
- klog.Errorf("send metrics server request failed: %v->%+v", url,
errs)
+ req, err := http.NewRequest("GET", url, nil)
Review Comment:
This change is for what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
