advancedxy commented on code in PR #491:
URL: https://github.com/apache/incubator-uniffle/pull/491#discussion_r1071942203
##########
deploy/kubernetes/operator/hack/Dockerfile:
##########
@@ -35,12 +35,9 @@ COPY pkg/ pkg/
# Build
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o
${MODULE} cmd/${MODULE}/main.go
-# Use distroless as minimal base image to package the manager binary
-# Refer to https://github.com/GoogleContainerTools/distroless for more details
-FROM alpine
-RUN apk add --update curl && \
- rm -rf /var/cache/apk/*
+FROM debian:11.6-slim
+ARG MODULE
WORKDIR /
COPY --from=builder /workspace/${MODULE} .
-
-CMD ["${MODULE}"]
Review Comment:
Previously, this is wrong:
1. the `ARG MODULE` is not defined in the second stage. the module might be
empty or undefined.
2. MODULE is only available in build time. You cannot start the container
by default since the `MODULE` env is not defined in the container.
cc @wangao1236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
