advancedxy commented on code in PR #510:
URL: https://github.com/apache/incubator-uniffle/pull/510#discussion_r1089856504
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -95,6 +96,10 @@ public ShuffleFlushManager(ShuffleServerConf
shuffleServerConf, String shuffleSe
while (true) {
try {
ShuffleDataFlushEvent event = flushQueue.take();
+ // Only for test
+ while (isSuspend) {
Review Comment:
To be honest, I don't think this is a good fix. Especially it complicates
the shuffle manager's logic just for test and the `setSuspend` method is opened
as public. It couples the normal logic and test specific logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
