kaijchen commented on code in PR #510:
URL: https://github.com/apache/incubator-uniffle/pull/510#discussion_r1089870547
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -95,6 +96,10 @@ public ShuffleFlushManager(ShuffleServerConf
shuffleServerConf, String shuffleSe
while (true) {
try {
ShuffleDataFlushEvent event = flushQueue.take();
+ // Only for test
+ while (isSuspend) {
Review Comment:
Thanks for the investigation @advancedxy, I prefer the 2nd way. It's always
better to improve testability.
If this test fails very often, we can merge this PR first and do the
refactor later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
