kaijchen commented on code in PR #510:
URL: https://github.com/apache/incubator-uniffle/pull/510#discussion_r1089878670
##########
server/src/test/java/org/apache/uniffle/server/buffer/ShuffleBufferManagerTest.java:
##########
@@ -567,7 +568,25 @@ public void shuffleFlushThreshold() throws Exception {
StorageManager storageManager =
StorageManagerFactory.getInstance().createStorageManager(conf);
ShuffleFlushManager shuffleFlushManager = new ShuffleFlushManager(conf,
- "serverId", mockShuffleServer, storageManager);
+ "serverId", mockShuffleServer, storageManager) {
+
+ @Override
+ protected void startEventProcesser() {
+ // do nothing
+ }
+
+ @Override
+ public void processEvents() {
Review Comment:
I think we shouldn't override `processEvents()`, because if
`ShuffleFlushManager#processEvents()` is changed, the test will pass no matter
if the change is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
