smallzhongfeng commented on code in PR #739:
URL: https://github.com/apache/incubator-uniffle/pull/739#discussion_r1141031976
##########
integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java:
##########
@@ -121,11 +122,29 @@ public void getShuffleRegisterInfoTest() {
@Test
public void getShuffleAssignmentsTest() throws Exception {
- String appId = "getShuffleAssignmentsTest";
+ final String appId = "getShuffleAssignmentsTest";
CoordinatorTestUtils.waitForRegister(coordinatorClient,2);
+ // When the shuffleServerHeartbeat Test is completed before the current
test,
+ // the server's tags will be [ss_v4, GRPC_NETTY] and [ss_v4, GRPC],
respectively.
+ // We need to remove the first machine's tag from GRPC_NETTY to GRPC
+ shuffleServers.get(0).stopServer();
+ ShuffleServerConf shuffleServerConf =
shuffleServers.get(0).getShuffleServerConf();
+ shuffleServerConf.setInteger("rss.rpc.server.port", SHUFFLE_SERVER_PORT +
3);
+ shuffleServerConf.setInteger("rss.jetty.http.port", 18089);
+ shuffleServerConf.setInteger(ShuffleServerConf.NETTY_SERVER_PORT, -3);
Review Comment:
I need to reset netty's port number to a negative number.
##########
integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java:
##########
@@ -121,11 +122,29 @@ public void getShuffleRegisterInfoTest() {
@Test
public void getShuffleAssignmentsTest() throws Exception {
- String appId = "getShuffleAssignmentsTest";
+ final String appId = "getShuffleAssignmentsTest";
CoordinatorTestUtils.waitForRegister(coordinatorClient,2);
+ // When the shuffleServerHeartbeat Test is completed before the current
test,
Review Comment:
https://github.com/apache/incubator-uniffle/blob/1021031b5eb1f4b97448f6431ea23e13a691b874/integration-test/common/src/test/java/org/apache/uniffle/test/CoordinatorGrpcTest.java#L249
Because this `shuffleServerConf` modifies the netty port number of a server,
there will be one less machine allocated. Therefore, in order to maintain the
original test, we need to set the port number back to a negative number, which
is equivalent to setting the label to `GRPC`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
