jerqi commented on code in PR #739:
URL: https://github.com/apache/incubator-uniffle/pull/739#discussion_r1141696219
##########
client/src/main/java/org/apache/uniffle/client/util/ClientUtils.java:
##########
@@ -122,4 +126,11 @@ public static void validateTestModeConf(boolean testMode,
String storageType) {
+ "because of the poor performance of these two types.");
}
}
+
+ public static void validateClientType(String clientType) {
Review Comment:
Could we convert this method to `CheckValue#checkValueFunc` like
`ConfigUtil#POSITIVE_LONG_VALIDATOR`?
##########
common/src/main/java/org/apache/uniffle/common/config/RssConf.java:
##########
@@ -645,4 +646,8 @@ public String getEnv(String key) {
return System.getenv(key);
}
+ @VisibleForTesting
+ public Map<String, Object> getSettings() {
Review Comment:
Could we remove this method? It seems unused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
