smallzhongfeng commented on code in PR #739:
URL: https://github.com/apache/incubator-uniffle/pull/739#discussion_r1141032063


##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java:
##########
@@ -400,7 +400,6 @@ public class ShuffleServerConf extends RssBaseConf {
   public static final ConfigOption<Integer> NETTY_SERVER_PORT = ConfigOptions
       .key("rss.server.netty.port")
       .intType()
-      .checkValue(ConfigUtils.POSITIVE_INTEGER_VALIDATOR_2, "netty port must 
be positive")

Review Comment:
   You can see 
https://github.com/apache/incubator-uniffle/pull/739#discussion_r1141031976 and 
 https://github.com/apache/incubator-uniffle/pull/739#discussion_r1141031669



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to