smallzhongfeng commented on code in PR #812:
URL: https://github.com/apache/incubator-uniffle/pull/812#discussion_r1163546744
##########
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java:
##########
@@ -39,13 +39,18 @@ public abstract class GRPCMetrics {
private static final String GRPC_TOTAL = "grpc_total";
private boolean isRegistered = false;
- protected Map<String, Counter> counterMap = JavaUtils.newConcurrentMap();
- protected Map<String, Gauge> gaugeMap = JavaUtils.newConcurrentMap();
- protected Map<String, Summary> transportTimeSummaryMap =
JavaUtils.newConcurrentMap();
- protected Map<String, Summary> processTimeSummaryMap =
JavaUtils.newConcurrentMap();
- private Gauge gaugeGrpcOpen;
- private Counter counterGrpcTotal;
+ protected Map<String, Counter.Child> counterMap =
JavaUtils.newConcurrentMap();
+ protected Map<String, Gauge.Child> gaugeMap = JavaUtils.newConcurrentMap();
+ protected Map<String, Summary.Child> transportTimeSummaryMap =
JavaUtils.newConcurrentMap();
+ protected Map<String, Summary.Child> processTimeSummaryMap =
JavaUtils.newConcurrentMap();
+ protected Gauge.Child gaugeGrpcOpen;
Review Comment:
If we use `guage`, there are too many areas that need to be modified, and
each metrics needs to be labeled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
