smallzhongfeng commented on code in PR #812:
URL: https://github.com/apache/incubator-uniffle/pull/812#discussion_r1163670144
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -473,4 +474,18 @@ public boolean isRunning() {
public int getNettyPort() {
return nettyPort;
}
+
+ public String coverToString() {
+ List<String> tags = shuffleServerConf.get(ShuffleServerConf.TAGS);
Review Comment:
I think so. But I think it can be done in followup pr. WDYT?
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServer.java:
##########
@@ -473,4 +474,18 @@ public boolean isRunning() {
public int getNettyPort() {
return nettyPort;
}
+
+ public String coverToString() {
+ List<String> tags = shuffleServerConf.get(ShuffleServerConf.TAGS);
+ StringBuilder sb = new StringBuilder();
+ sb.append(Constants.SHUFFLE_SERVER_VERSION);
+ if (tags == null || tags.size() == 0) {
+ return sb.toString();
+ }
+ for (String tag : tags) {
+ sb.append("_");
Review Comment:
like this, default tag is `ss_v4`, and the config `rss.server.tags` is
`low_priority`. So I think `'_'` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
