advancedxy commented on code in PR #812:
URL: https://github.com/apache/incubator-uniffle/pull/812#discussion_r1163791245
##########
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java:
##########
@@ -127,7 +129,7 @@ public void incCounter(String methodName) {
public void decCounter(String methodName) {
if (isRegistered) {
- Gauge gauge = gaugeMap.get(methodName);
+ Gauge.Child gauge = gaugeMap.get(methodName);
Review Comment:
Yes...
I did some code review... It might be too much to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
