advancedxy commented on code in PR #812:
URL: https://github.com/apache/incubator-uniffle/pull/812#discussion_r1165182712
##########
common/src/main/java/org/apache/uniffle/common/metrics/GRPCMetrics.java:
##########
@@ -153,31 +158,43 @@ public CollectorRegistry getCollectorRegistry() {
return metricsManager.getCollectorRegistry();
}
- public Map<String, Counter> getCounterMap() {
+ public Map<String, Counter.Child> getCounterMap() {
return counterMap;
}
- public Map<String, Gauge> getGaugeMap() {
+ public Map<String, Gauge.Child> getGaugeMap() {
return gaugeMap;
}
- public Gauge getGaugeGrpcOpen() {
+ public Gauge.Child getGaugeGrpcOpen() {
return gaugeGrpcOpen;
}
- public Counter getCounterGrpcTotal() {
+ public Counter.Child getCounterGrpcTotal() {
return counterGrpcTotal;
}
- public Map<String, Summary> getTransportTimeSummaryMap() {
+ public Map<String, Summary.Child> getTransportTimeSummaryMap() {
return transportTimeSummaryMap;
}
- public Map<String, Summary> getProcessTimeSummaryMap() {
+ public Map<String, Summary.Child> getProcessTimeSummaryMap() {
return processTimeSummaryMap;
}
public static GRPCMetrics getEmptyGRPCMetrics() {
- return new EmptyGRPCMetrics();
+ return new EmptyGRPCMetrics(Constants.SHUFFLE_SERVER_VERSION);
+ }
+
+ protected Summary.Child addSummary(String
grpcSendShuffleDataTransportLatency) {
Review Comment:
I'm not sure, is it necessary to define this and the following methods here?
Even if you are going to define methods here, it should be called as
`addLabeledSummary` here and the parameter name should be generic, such as
`name`, rather than `grpcSendShuffleDataTransportLatency`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
