advancedxy commented on code in PR #812:
URL: https://github.com/apache/incubator-uniffle/pull/812#discussion_r1163824794
##########
common/src/main/java/org/apache/uniffle/common/util/Constants.java:
##########
@@ -23,7 +23,9 @@ private Constants() {
}
// the value is used for client/server compatible, eg, online upgrade
+ public static final String SHUFFLE_SERVER_TAGS = "label";
Review Comment:
This might not be accurate.
It might be called as `METRICS_TAG_LABEL_NAME`? Since coordinator also uses
this label name to add label.
BTW, you should move L25(the comment line) together with L27, they are
grouped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
