lifeSo commented on code in PR #1058:
URL: 
https://github.com/apache/incubator-uniffle/pull/1058#discussion_r1280865709


##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -408,6 +408,10 @@ public long getPartitionDataSize(String appId, int 
shuffleId, int partitionId) {
 
   public long requireBuffer(
       String appId, int shuffleId, List<Integer> partitionIds, int 
requireSize) {
+    boolean isRegistered = shuffleBufferManager.checkIfRegistered(appId, 
shuffleId, partitionIds);
+    if (!isRegistered) {
+      return -4; // Keep the same with StatusCode

Review Comment:
   I find there is no error code existed I can use, and I craete 
RequireBufferStatusCode



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to