jerqi commented on code in PR #1058:
URL:
https://github.com/apache/incubator-uniffle/pull/1058#discussion_r1283951524
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -409,14 +410,15 @@ public long getPartitionDataSize(String appId, int
shuffleId, int partitionId) {
public long requireBuffer(
String appId, int shuffleId, List<Integer> partitionIds, int
requireSize) {
ShuffleTaskInfo shuffleTaskInfo = shuffleTaskInfos.get(appId);
- if (shuffleTaskInfo != null) {
- for (int partitionId : partitionIds) {
- long partitionUsedDataSize = getPartitionDataSize(appId, shuffleId,
partitionId);
- if (shuffleBufferManager.limitHugePartition(
- appId, shuffleId, partitionId, partitionUsedDataSize)) {
-
ShuffleServerMetrics.counterTotalRequireBufferFailedForHugePartition.inc();
- return -1;
- }
+ if (null == shuffleTaskInfo && !"EMPTY".equals(appId)) {
Review Comment:
Why do we add `EMPTY` here? It's weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
