zuston commented on code in PR #1058:
URL:
https://github.com/apache/incubator-uniffle/pull/1058#discussion_r1286659327
##########
client-tez/src/main/java/org/apache/tez/runtime/library/common/shuffle/impl/RssTezFetcher.java:
##########
@@ -133,7 +133,7 @@ public void copyFromRssServer() throws IOException {
hasPendingData = false;
uncompressedData = null;
} else {
- LOG.info("uncompressedData is null");
+ LOG.info("UncompressedData is null");
Review Comment:
I think this is not related with current issue.
Anyway, let's reserve these changes.
##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -409,14 +410,15 @@ public long getPartitionDataSize(String appId, int
shuffleId, int partitionId) {
public long requireBuffer(
String appId, int shuffleId, List<Integer> partitionIds, int
requireSize) {
ShuffleTaskInfo shuffleTaskInfo = shuffleTaskInfos.get(appId);
- if (shuffleTaskInfo != null) {
- for (int partitionId : partitionIds) {
- long partitionUsedDataSize = getPartitionDataSize(appId, shuffleId,
partitionId);
- if (shuffleBufferManager.limitHugePartition(
- appId, shuffleId, partitionId, partitionUsedDataSize)) {
-
ShuffleServerMetrics.counterTotalRequireBufferFailedForHugePartition.inc();
- return -1;
- }
+ if (null == shuffleTaskInfo) {
+ return RequireBufferStatusCode.NO_REGISTER.statusCode();
+ }
+ for (int partitionId : partitionIds) {
Review Comment:
I think the change is right. But I will introduce new grpc status code like
`BUFFER_LIMIT_FOR_HUGE_PARTITION` instead of `NO_BUFFER`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
