zhengchenyu commented on code in PR #1121:
URL:
https://github.com/apache/incubator-uniffle/pull/1121#discussion_r1289922912
##########
common/src/test/java/org/apache/uniffle/common/RemoteStorageInfoTest.java:
##########
@@ -119,4 +119,14 @@ public void testHashCode() {
RemoteStorageInfo info1 = new RemoteStorageInfo(TEST_PATH, CONF_STRING);
assertEquals(info.hashCode(), info1.hashCode());
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"k1=v1\\,v11,k2=v2\\,v22"})
Review Comment:
> > > +1, We can add a new configuration and parsing way to meet new
requirements, while keeping the original way for compatibility.
> >
> >
> > @LuciferYang I can not catch you mean. I think we can not keep
compatible.
>
> We add a new configuration option like
>
> ```
> rss.coordinator.remote.storage.conf
> ```
>
> We don't change the old config option to keep compatible.
I got it! Thanks very much!
But I have a little doubt. rss.coordinator.remote.storage.conf may be
conflict with rss.coordinator.remote.storage.cluster.conf.
```
rss.coordinator.remote.storage.conf.clustera k1=value1;k2=value2
rss.coordinator.remote.storage.conf.clusterb k1=value1;k2=value2
rss.coordinator.remote.storage.cluster.conf
clustera,k1=v1,k2=v2;clusterb,k1=v1,k2=v2
```
In upper code, I can not make sure which config the coordinator loaded?
We load all config, if found some conflict, we use new config. Is it ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
