advancedxy commented on code in PR #1121:
URL:
https://github.com/apache/incubator-uniffle/pull/1121#discussion_r1290326328
##########
common/src/test/java/org/apache/uniffle/common/RemoteStorageInfoTest.java:
##########
@@ -119,4 +119,14 @@ public void testHashCode() {
RemoteStorageInfo info1 = new RemoteStorageInfo(TEST_PATH, CONF_STRING);
assertEquals(info.hashCode(), info1.hashCode());
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"k1=v1\\,v11,k2=v2\\,v22"})
Review Comment:
Sorry for the late reply. However it's common and easy to use "`" to quote a
complex string in SQL, I think we can adopt it in this remote storage conf. So
it's basically
```
rss.coordinator.remote.storage.cluster.conf
clusterA,a=b,c=d;clusterB,a=`b,c`,key=value
# or to quote it in the kv pair
rss.coordinator.remote.storage.cluster.conf
clusterA,a=b,c=d;clusterB,`a=b,c`,key=value
```
In that way, `b,c` or `a=b,c` is treated as a single element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
