jerqi commented on code in PR #1121:
URL:
https://github.com/apache/incubator-uniffle/pull/1121#discussion_r1289804706
##########
common/src/test/java/org/apache/uniffle/common/RemoteStorageInfoTest.java:
##########
@@ -119,4 +119,14 @@ public void testHashCode() {
RemoteStorageInfo info1 = new RemoteStorageInfo(TEST_PATH, CONF_STRING);
assertEquals(info.hashCode(), info1.hashCode());
}
+
+ @ParameterizedTest
+ @ValueSource(strings = {"k1=v1\\,v11,k2=v2\\,v22"})
Review Comment:
@zhengchenyu Could we split the
```
rss.coordinator.remote.storage.path
clustera,k1=v1,k2=v2;clusterb,k1=v1,k2=v2;clusterc,k1=v1,k2=v2;
```
into
```
rss.coordinator.remote.storage.path.clustera k1=v1,v2;k2=v3
rss.coordinator.remote.storage.path.clusterb k1=v1;k2=v2
rss.coordinator.remote.storage.path.clusterc k1=v1;k2=v2
```
It seems more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
