yl09099 commented on code in PR #1138:
URL:
https://github.com/apache/incubator-uniffle/pull/1138#discussion_r1354328497
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/DataPusher.java:
##########
@@ -118,6 +125,18 @@ private synchronized void putBlockId(
.addAll(blockIds);
}
+ private synchronized void putBlockIdAndShuffle(
Review Comment:
> 1. Could we give this method a better name? I can't get the point of `put
shuffle`.
> 2. Will it influence the performance of pusher if we use the lock here?
1. The name has been changed.
2. The lock here is the same logic as the putBlockId method above and should
not affect it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
