yl09099 commented on code in PR #1138:
URL:
https://github.com/apache/incubator-uniffle/pull/1138#discussion_r1366858222
##########
client-mr/core/src/test/java/org/apache/hadoop/mapred/SortWriteBufferManagerTest.java:
##########
@@ -382,7 +383,8 @@ public SendShuffleDataResult sendShuffleData(
if (mode == 0) {
throw new RssException("send data failed");
} else if (mode == 1) {
- return new SendShuffleDataResult(Sets.newHashSet(2L),
Sets.newHashSet(1L));
+ return new SendShuffleDataResult(
+ Sets.newHashSet(2L), Sets.newHashSet(1L), Maps.newHashMap());
Review Comment:
> I don't think this line is needed? Since the constructor of
`SentShuffleDataResult` is kept for compatibility.
Have been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
