yl09099 commented on code in PR #1138:
URL:
https://github.com/apache/incubator-uniffle/pull/1138#discussion_r1366863012
##########
client-spark/spark3/src/main/java/org/apache/spark/shuffle/RssShuffleManager.java:
##########
@@ -986,4 +992,18 @@ private Roaring64NavigableMap getShuffleResultForMultiPart(
e, sparkConf, appId, shuffleId, stageAttemptId, failedPartitions);
}
}
+
+ /**
+ * The ShuffleServer list of block sending failures is returned using the
shuffle task ID
+ *
+ * @param taskId Shuffle taskId
+ * @return List of failed ShuffleServer blocks
+ */
+ public Map<Long, List<ShuffleServerInfo>>
getFailedBlockIdsWithShuffleServer(String taskId) {
Review Comment:
> when is this method called?
>
> And it seems a bit unusual to return an empty map without putting it back
to the `taskToFailedBlockIdsAndServer`.
Later PR will call this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
