jerqi commented on code in PR #1537:
URL:
https://github.com/apache/incubator-uniffle/pull/1537#discussion_r1500369179
##########
server/src/main/java/org/apache/uniffle/server/DefaultFlushEventHandler.java:
##########
@@ -126,6 +126,11 @@ private void
handleEventAndUpdateMetrics(ShuffleDataFlushEvent event, Storage st
if (e instanceof EventInvalidException) {
return;
}
+
+ LOG.error(
+ "Unexpected exceptions happened when handling the flush event: {},
due to ", event, e);
+ // We need to release the memory when unexpected exceptions happened
+ event.doCleanup();
Review Comment:
Should we put the logic to the code block finally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
