EnricoMi commented on code in PR #1537:
URL:
https://github.com/apache/incubator-uniffle/pull/1537#discussion_r1500762019
##########
server/src/main/java/org/apache/uniffle/server/DefaultFlushEventHandler.java:
##########
@@ -126,6 +126,11 @@ private void
handleEventAndUpdateMetrics(ShuffleDataFlushEvent event, Storage st
if (e instanceof EventInvalidException) {
return;
Review Comment:
Reasonable. Maybe it is worth mentioning this fact here. Something like
```suggestion
// invalid events have already been released / cleaned up so no need
to call event.doCleanup() here
return;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
