rickyma commented on code in PR #1537:
URL:
https://github.com/apache/incubator-uniffle/pull/1537#discussion_r1500629483
##########
server/src/main/java/org/apache/uniffle/server/DefaultFlushEventHandler.java:
##########
@@ -126,6 +126,11 @@ private void
handleEventAndUpdateMetrics(ShuffleDataFlushEvent event, Storage st
if (e instanceof EventInvalidException) {
return;
Review Comment:
This is because once the `ShuffleBuffer` associated with the `appId`
expires, its corresponding `bufferPool` will be cleared by a scheduled task.
Consequently, the `event` related to the `appId` will become `inValid`, and
there is no need to repeatedly release memory, as the scheduled task has
already taken care of releasing the buffer memory for all events associated
with that `appId`. You can check the code for more detailed reasons. @EnricoMi
As for why the code is designed this way, you can ask @zuston
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
