EnricoMi commented on code in PR #1528:
URL:
https://github.com/apache/incubator-uniffle/pull/1528#discussion_r1510225901
##########
client-tez/src/main/java/org/apache/tez/common/RssTezUtils.java:
##########
@@ -53,17 +53,17 @@
import org.apache.uniffle.client.factory.ShuffleClientFactory;
import org.apache.uniffle.common.ShuffleServerInfo;
import org.apache.uniffle.common.exception.RssException;
-import org.apache.uniffle.common.util.BlockId;
+import org.apache.uniffle.common.util.BlockIdLayout;
import org.apache.uniffle.common.util.Constants;
public class RssTezUtils {
Review Comment:
Logic is unchanged and layout is not configurable for TEZ, so there is
nothing new that needs to be tested.
If existing tests are incomplete, I'd suggest someone who has a deeper
understanding of the internals of TEZ task attempt ids than I have adds more
coverage in a separate PR. I am happy to adjust them afterwards in this PR.
Alternatively, the coverage could be increased when adding configurable block
id layout for TEZ in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
