EnricoMi commented on code in PR #1528:
URL:
https://github.com/apache/incubator-uniffle/pull/1528#discussion_r1510649895
##########
common/src/main/java/org/apache/uniffle/common/segment/FixedSizeSegmentSplitter.java:
##########
@@ -84,11 +83,10 @@ private static List<ShuffleDataSegment>
transIndexDataToSegments(
if (dataFileLen != -1 && totalLength > dataFileLen) {
LOGGER.info(
"Abort inconsistent data, the data length: {}(bytes) recorded in
index file is greater than "
- + "the real data file length: {}(bytes). Partition id: {}. "
+ + "the real data file length: {}(bytes). "
+ "This may happen when the data is flushing, please
ignore.",
totalLength,
- dataFileLen,
- BlockId.getPartitionId(blockId));
Review Comment:
The actual block id layout is not available here, and wiring it through from
the client would mean to add it to many method signature calls. All this only
for logging.
At least we should log the `long` block id here so it can be de-cyphered
manually if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
