EnricoMi commented on code in PR #1528:
URL:
https://github.com/apache/incubator-uniffle/pull/1528#discussion_r1510845420
##########
server/src/main/java/org/apache/uniffle/server/ShuffleServerGrpcService.java:
##########
@@ -528,6 +529,11 @@ public void getShuffleResult(
String appId = request.getAppId();
int shuffleId = request.getShuffleId();
int partitionId = request.getPartitionId();
+ BlockIdLayout blockIdLayout =
Review Comment:
Yes, what do you suggest? Use `BlockIdLayout.DEFAULT` if
`request.getBlockIdLayout == null` and mark this a breaking change for users
that deployed a cluster with modified bit lengths in `Constants.java`? How can
we make this compatible for those users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
