jerqi commented on code in PR #1610:
URL:
https://github.com/apache/incubator-uniffle/pull/1610#discussion_r1548842553
##########
client-spark/common/src/test/java/org/apache/spark/shuffle/writer/WriteBufferManagerTest.java:
##########
@@ -371,6 +372,11 @@ public void spillByOwnTest() {
long sum = 0L;
List<AddBlockEvent> events = wbm.buildBlockEvents(blocks);
for (AddBlockEvent event : events) {
+ TupleConsumer<ShuffleBlockInfo, Boolean> blockProcessedCallback =
Review Comment:
`blockProcessedCallback ` -> `blockSentCallback`.
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/AddBlockEvent.java:
##########
@@ -21,12 +21,14 @@
import java.util.List;
import org.apache.uniffle.common.ShuffleBlockInfo;
+import org.apache.uniffle.common.function.TupleConsumer;
public class AddBlockEvent {
private String taskId;
private List<ShuffleBlockInfo> shuffleDataInfoList;
private List<Runnable> processedCallbackChain;
+ private TupleConsumer<ShuffleBlockInfo, Boolean> blockSentCallback;
Review Comment:
Could we give a more unify design between processedCallbackChain and
blockSentCallback?
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/AddBlockEvent.java:
##########
@@ -59,6 +61,14 @@ public List<Runnable> getProcessedCallbackChain() {
return processedCallbackChain;
}
+ public void withBlockSentCallback(TupleConsumer<ShuffleBlockInfo, Boolean>
blockSentCallback) {
+ this.blockSentCallback = blockSentCallback;
+ }
+
+ public TupleConsumer<ShuffleBlockInfo, Boolean> getBlockSentCallback() {
Review Comment:
Maybe we should have a method `executeSentCallback` instead of
`getBlockSentCallback()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
