jerqi commented on code in PR #1610:
URL:
https://github.com/apache/incubator-uniffle/pull/1610#discussion_r1548890084
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/writer/AddBlockEvent.java:
##########
@@ -61,16 +54,30 @@ public List<Runnable> getProcessedCallbackChain() {
return processedCallbackChain;
}
- public void withBlockSentCallback(TupleConsumer<ShuffleBlockInfo, Boolean>
blockSentCallback) {
- this.blockSentCallback = blockSentCallback;
+ @Override
+ public String toString() {
+ return "AddBlockEvent: TaskId[" + taskId + "], " + shuffleDataInfoList;
}
- public TupleConsumer<ShuffleBlockInfo, Boolean> getBlockSentCallback() {
- return blockSentCallback;
+ public void callbackOnBlockFailure(ShuffleBlockInfo block) {
+ if (block == null) {
+ return;
+ }
+ this.blockFailureCallback.onBlockFailure(block);
}
- @Override
- public String toString() {
- return "AddBlockEvent: TaskId[" + taskId + "], " + shuffleDataInfoList;
+ public void callbackOnBlockSuccess(ShuffleBlockInfo block) {
Review Comment:
The name of the method seems weird. Let us think a better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
